Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Extend the list of possible connections to GitHub #640

Merged
merged 1 commit into from
Oct 21, 2024
Merged

chore: Extend the list of possible connections to GitHub #640

merged 1 commit into from
Oct 21, 2024

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Introduced alternative function for communicating with GitHub API using token.
Added unit tests where possible.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Local run of unit tests.

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added the enhancement New feature or request label Oct 21, 2024
@o-kopysov o-kopysov added this to the v2.0.2 milestone Oct 21, 2024
@o-kopysov o-kopysov self-assigned this Oct 21, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.63%. Comparing base (84b9ba1) to head (954feb8).

Files with missing lines Patch % Lines
.../com/lpvs/service/LPVSGitHubConnectionService.java 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #640      +/-   ##
============================================
- Coverage     93.80%   93.63%   -0.17%     
- Complexity      634      635       +1     
============================================
  Files            52       52              
  Lines          2178     2185       +7     
  Branches        254      255       +1     
============================================
+ Hits           2043     2046       +3     
- Misses           58       62       +4     
  Partials         77       77

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

t-naumenko
t-naumenko approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit 26d4ae7 into main Oct 21, 2024
10 checks passed
@o-kopysov o-kopysov deleted the maint-fix branch October 21, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-naumenko t-naumenko t-naumenko approved these changes

@tdrozdovsky tdrozdovsky tdrozdovsky approved these changes

@o-konoval o-konoval Awaiting requested review from o-konoval

@m-rudyk m-rudyk Awaiting requested review from m-rudyk

@tiokim tiokim Awaiting requested review from tiokim tiokim is a code owner

@MoonkiHong MoonkiHong Awaiting requested review from MoonkiHong MoonkiHong is a code owner

Assignees

@o-kopysov o-kopysov

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@o-kopysov @codecov-commenter @tdrozdovsky @t-naumenko